[stable33] fix(sharing): Prevent empty password when checkbox is enabled#59090
Open
backportbot[bot] wants to merge 3 commits intostable33from
Open
[stable33] fix(sharing): Prevent empty password when checkbox is enabled#59090backportbot[bot] wants to merge 3 commits intostable33from
backportbot[bot] wants to merge 3 commits intostable33from
Conversation
nfebe
approved these changes
Mar 23, 2026
nfebe
force-pushed
the
backport/58226/stable33
branch
from
a51ed15 to
4754104
Compare
Contributor
|
/backport to stable32 |
Set passwordProtectedState explicitly when initializing shares with default passwords. This ensures the checkbox state is tracked independently of the password value, preventing it from unchecking when the password field is cleared. Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings. Added passWithNoTests to vitest configs to handle Vue 2/3 dual frontend test runs gracefully. Fixes: #57732, #57011 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
backport/58226/stable33
branch
from
4754104 to
903d568
Compare
nfebe
requested review from
skjnldsv and
sorbaugh
and removed request for
a team
Contributor
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58226
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.